Use native variable validation#14
Open
haampie wants to merge 3 commits into
Open
Conversation
* Use null utility `: ...` to avoid execution
* Use `${parameter:?[word]}` to do ensure the variable is set
* Drop `eval` loop
The error message on Ubuntu reads:
> cc.sh: 205: SPACK_COMPILER_WRAPPER_PATH: Error: compiler wrapper must be invoked by Spack
Previously it was:
> [spack cc]: Error: Spack compiler must be run from Spack! Input 'SPACK_COMPILER_WRAPPER_PATH' is missing.
Signed-off-by: Harmen Stoppels <me@harmenstoppels.nl>
Signed-off-by: Harmen Stoppels <me@harmenstoppels.nl>
haampie
force-pushed
the
hs/fix/input-validation
branch
from
bdecef3 to
af82ea1
Compare
Signed-off-by: Harmen Stoppels <me@harmenstoppels.nl>
haampie
force-pushed
the
hs/fix/input-validation
branch
from
af82ea1 to
ea60e01
Compare
| fi | ||
| done | ||
| # Ensure required variables are set | ||
| : "${SPACK_COMPILER_WRAPPER_PATH:?Error: the compiler wrapper must be invoked from Spack}" |
Collaborator
There was a problem hiding this comment.
require_spack_env()
{
_msg="Error: the compiler wrapper must be invoked from Spack"
eval '": \"\${$1:?$_msg}\""
}
require_spack_env SPACK_COMPILER_WRAPPER_PATH
require_spack_env SPACK_DEBUG_LOG_DIR
require_spack_env SPACK_DEBUG_LOG_ID
require_spack_env SPACK_SHORT_SPEC
require_spack_env SPACK_SYSTEM_DIRS
require_spack_env SPACK_MANAGED_DIRS
Member
Author
There was a problem hiding this comment.
One of my goals was to get rid of eval
Collaborator
There was a problem hiding this comment.
The thing I really want is the pull the message out as a variable to not have to copy-paste the string. idk what I was doing wrong earlier, but it seems you should be able to do
_msg="..."
: "${SPACK_VAR:?$_msg}"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
: ...to avoid execution${parameter:?[word]}to ensure the variable is setevalloopThe error message on Ubuntu reads:
Previously it was: